hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhihong Yu (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5790) ZKUtil deleteRecurisively should be a recoverable operation
Date Sat, 14 Apr 2012 04:19:57 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253984#comment-13253984
] 

Zhihong Yu commented on HBASE-5790:
-----------------------------------

{code}
+   * Recursively delete the path all children on that path.
{code}
'the path all' -> 'all the'.
{code}
+          retryOrThrow(retryCounter, e, "delete");
{code}
"delete" should be "deleteRecursively".
{code}
+  private void addAllChildrenToDeleteTransaction(Transaction trans, String path, int version)
{code}
I don't see how version is used to filter child nodes in the above method.

                
> ZKUtil deleteRecurisively should be a recoverable operation
> -----------------------------------------------------------
>
>                 Key: HBASE-5790
>                 URL: https://issues.apache.org/jira/browse/HBASE-5790
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Jesse Yates
>            Assignee: Jesse Yates
>              Labels: zookeeper
>             Fix For: 0.96.0, 0.94.1
>
>         Attachments: java_HBASE-5790.patch
>
>
> As of 3.4.3 Zookeeper now has full, multi-operation transaction. This means we can wholesale
delete chunks of the zk tree and ensure that we don't have any pesky recursive delete issues
where we delete the children of a node, but then a child joins before deletion of the parent.
Even without transactions, this should be the behavior, but it is possible to make it much
cleaner now that we have this new feature in zk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message