hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5635) If getTaskList() returns null, splitlogWorker would go down and it won't serve any requests
Date Mon, 23 Apr 2012 16:51:35 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259710#comment-13259710
] 

ramkrishna.s.vasudevan commented on HBASE-5635:
-----------------------------------------------

Committed to trunk and 0.94.  The testcase failure is not due to this patch. Ran TestSplitLogManager
multiple times and did not fail.

Thanks for the patch Chinna.
Thanks for the review Ted, Lars and Anoop.

                
> If getTaskList() returns null, splitlogWorker would go down and it won't serve any requests
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5635
>                 URL: https://issues.apache.org/jira/browse/HBASE-5635
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>    Affects Versions: 0.92.1
>            Reporter: Kristam Subba Swathi
>         Attachments: HBASE-5635.1.patch, HBASE-5635.2.patch, HBASE-5635._trunk.patch,
HBASE-5635.patch, HBASE-5635_0.94.patch
>
>
> During the hlog split operation if all the zookeepers are down ,then the paths will be
returned as null and the splitworker thread wil be exited
> Now this regionserver wil not be able to acquire any other tasks since the splitworker
thread is exited
> Please find the attached code for more details
> {code}
> private List<String> getTaskList() {
>     for (int i = 0; i < zkretries; i++) {
>       try {
>         return (ZKUtil.listChildrenAndWatchForNewChildren(this.watcher,
>             this.watcher.splitLogZNode));
>       } catch (KeeperException e) {
>         LOG.warn("Could not get children of znode " +
>             this.watcher.splitLogZNode, e);
>         try {
>           Thread.sleep(1000);
>         } catch (InterruptedException e1) {
>           LOG.warn("Interrupted while trying to get task list ...", e1);
>           Thread.currentThread().interrupt();
>           return null;
>         }
>       }
>     }
> {code}
> in the org.apache.hadoop.hbase.regionserver.SplitLogWorker 
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message