hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5785) Adding unit tests for protbuf utils introduced for HRegionInterface pb conversion
Date Fri, 27 Apr 2012 17:20:47 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13263812#comment-13263812
] 

Hadoop QA commented on HBASE-5785:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12524879/hbase-5785.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 2 new or modified tests.

    +1 hadoop23.  The patch compiles against the hadoop 0.23.x profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.replication.TestReplication

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1669//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1669//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1669//console

This message is automatically generated.
                
> Adding unit tests for protbuf utils introduced for HRegionInterface pb conversion
> ---------------------------------------------------------------------------------
>
>                 Key: HBASE-5785
>                 URL: https://issues.apache.org/jira/browse/HBASE-5785
>             Project: HBase
>          Issue Type: Sub-task
>          Components: ipc, master, migration, regionserver
>    Affects Versions: 0.96.0
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Critical
>              Labels: noob
>             Fix For: 0.96.0
>
>         Attachments: hbase-5785.patch
>
>
> We need to add some unit tests for the probuf utilities to catch issues earlier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message