hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5717) Scanner metrics are only reported if you get to the end of a scanner
Date Thu, 05 Apr 2012 19:46:25 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247573#comment-13247573
] 

Hadoop QA commented on HBASE-5717:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12521548/ClientScanner_HBASE_5717-v3.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.master.TestSplitLogManager

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1409//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1409//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1409//console

This message is automatically generated.
                
> Scanner metrics are only reported if you get to the end of a scanner
> --------------------------------------------------------------------
>
>                 Key: HBASE-5717
>                 URL: https://issues.apache.org/jira/browse/HBASE-5717
>             Project: HBase
>          Issue Type: Bug
>          Components: client, metrics
>            Reporter: Ian Varley
>            Priority: Minor
>         Attachments: ClientScanner_HBASE_5717-v2.patch, ClientScanner_HBASE_5717-v3.patch,
ClientScanner_HBASE_5717.patch
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> When you turn on Scanner Metrics, the metrics are currently only made available if you
run over all records available in the scanner. If you stop iterating before the end, the values
are never flushed into the metrics object (in the Scan attribute).
> Will supply a patch with fix and test.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message