hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhihong Yu (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-2214) Do HBASE-1996 -- setting size to return in scan rather than count of rows -- properly
Date Sat, 14 Apr 2012 14:03:16 GMT

    [ https://issues.apache.org/jira/browse/HBASE-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254116#comment-13254116
] 

Zhihong Yu commented on HBASE-2214:
-----------------------------------

{code}
+   * @return the maximum buffer size in bytes. Also see 
+   * {@link #setMaxBufferSize(int)}
{code}
'Also see' -> 'See also'. The parameter type for setMaxBufferSize() should be long.
Since line length is 100 now, you can combine the two lines together.

On review board, it is clear to see the white spaces in the patch.

Trunk build is currently broken, please submit patch for Hadoop QA when trunk build passes.
                
> Do HBASE-1996 -- setting size to return in scan rather than count of rows -- properly
> -------------------------------------------------------------------------------------
>
>                 Key: HBASE-2214
>                 URL: https://issues.apache.org/jira/browse/HBASE-2214
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: stack
>            Assignee: Ferdy Galema
>             Fix For: 0.94.0
>
>         Attachments: HBASE-2214-0.94.txt, HBASE-2214_with_broken_TestShell.txt
>
>
> The notion that you set size rather than row count specifying how many rows a scanner
should return in each cycle was raised over in hbase-1966.  Its a good one making hbase "regular"
though the data under it may vary.  HBase-1966 was committed but the patch was constrained
by the fact that it needed to not change RPC interface.  This issue is about doing hbase-1966
for 0.21 in a clean, unconstrained way.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message