hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5893) Allow spaces in coprocessor conf (aka trim() className)
Date Fri, 27 Apr 2012 22:50:50 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264058#comment-13264058
] 

Hadoop QA commented on HBASE-5893:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12524934/HBASE-5893-v0.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 hadoop23.  The patch compiles against the hadoop 0.23.x profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1674//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1674//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1674//console

This message is automatically generated.
                
> Allow spaces in coprocessor conf (aka trim() className)
> -------------------------------------------------------
>
>                 Key: HBASE-5893
>                 URL: https://issues.apache.org/jira/browse/HBASE-5893
>             Project: HBase
>          Issue Type: Bug
>          Components: coprocessors
>    Affects Versions: 0.92.1, 0.94.0, 0.96.0
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Minor
>              Labels: conf, coprocessors
>         Attachments: HBASE-5893-v0.patch
>
>
> This is annoying especially for coprocessors where you've long class name.
> but maybe is a bug of Configuration.getStrings() that doesn't trim each string.
> When you've comma separated values like in the coprocessors case, you've to pack together
your values without spaces ("v1,v2,v3,...") otherwise the coprocessor is not loaded because
the class name with spaces is not found.
> {code}
> <property>
>    <name>hbase.coprocessor.master.classes</name>
>    <value>
>     org.apache.hadoop.hbase.security.token.TokenProvider,
>     org.apache.hadoop.hbase.security.access.AccessController
>    </value>
> </property>
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message