hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5802) Change the default metrics class to NullContextWithUpdateThread
Date Tue, 17 Apr 2012 04:17:51 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255295#comment-13255295

stack commented on HBASE-5802:

So, enable jmx emissions?  Would suggest that your patch include comment explaining what the
exotic-sounding NullContextWithUpdateThread does.  Maybe copy the class comment into your
patch somewhere:

 * A null context which has a thread calling
 * periodically when monitoring is started. This keeps the data sampled
 * correctly.
 * In all other respects, this is like the NULL context: No data is emitted.
 * This is suitable for Monitoring systems like JMX which reads the metrics
 *  when someone reads the data from JMX.
 * The default impl of start and stop monitoring:
 *  is the AbstractMetricsContext is good enough.

Maybe update the reference guide too especially if you are changing default.

Good stuff E.
> Change the default metrics class to NullContextWithUpdateThread
> ---------------------------------------------------------------
>                 Key: HBASE-5802
>                 URL: https://issues.apache.org/jira/browse/HBASE-5802
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>            Priority: Minor
>         Attachments: HBASE-5802-0.patch
> Since lots more metrics are being placed into the Dynamic metrics bucket changing the
default class to NullContextWithUpdateThread seems like it might be worth it.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message