hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hsieh (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs
Date Mon, 16 Apr 2012 13:30:17 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254683#comment-13254683
] 

Jonathan Hsieh commented on HBASE-5654:
---------------------------------------

Ashutosh:  Thanks for taking this on.

I'm about half way through the excludes.  Just starting the INT category.

Questions:
* why no fix?: WritableRcpEngine#getProxy
* why no fix?: Ambiguous invocations in RounRobinPool/ReusablePool  (specify scope of get()
by changing to this.get() or ReusablePool.this.get())
* add bounds checks? 	Result of integer multiplication cast to long in org.apache.hadoop.hbase.io.hfile.LruBlockCache.calculateOverhead(long,
long, int)
	Result of integer multiplication cast to long in org.apache.hadoop.hbase.regionserver.IncreasingToUpperBoundRegionSplitPolicy.getSizeToCheck(int)

                
> [findbugs] Address dodgy bugs
> -----------------------------
>
>                 Key: HBASE-5654
>                 URL: https://issues.apache.org/jira/browse/HBASE-5654
>             Project: HBase
>          Issue Type: Sub-task
>          Components: scripts
>    Affects Versions: 0.96.0
>            Reporter: Jonathan Hsieh
>            Assignee: Ashutosh Jindal
>              Labels: patch
>             Fix For: 0.96.0
>
>         Attachments: Hbase-5654.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_STYLE
> This may be broken down further.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message