hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jimmy Xiang (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB
Date Tue, 17 Apr 2012 16:33:19 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255704#comment-13255704
] 

Jimmy Xiang commented on HBASE-5620:
------------------------------------

@Stack, not every invocation will throw an exception.  In case it throws an exception, it
should be a ServiceException for pb.  It used to be IOException.  Without the change, for
pb calls, it won't get a ServiceException in case something goes wrong.  It gets an undeclared
exception
with the cause to be an IOE, and the upper layer doesn't know how to handle it.

The Set in Invocation is used to decide if a protocol a pb one, so ServiceException should
be used.  I put it there because it is
used for both WritableRpcEngine and SecureRpcEngine.

                
> Convert the client protocol of HRegionInterface to PB
> -----------------------------------------------------
>
>                 Key: HBASE-5620
>                 URL: https://issues.apache.org/jira/browse/HBASE-5620
>             Project: HBase
>          Issue Type: Sub-task
>          Components: ipc, master, migration, regionserver
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.96.0
>
>         Attachments: hbase-5620-sec.patch, hbase-5620_v3.patch, hbase-5620_v4.patch,
hbase-5620_v4.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message