hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5717) Scanner metrics are only reported if you get to the end of a scanner
Date Thu, 05 Apr 2012 18:16:25 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247457#comment-13247457
] 

jiraposter@reviews.apache.org commented on HBASE-5717:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4640/
-----------------------------------------------------------

(Updated 2012-04-05 18:15:41.419224)


Review request for hbase.


Changes
-------

Added finally block (with try/catch inside). I'd prefer to also add logging rather than swallowing
the exceptions, but that seems like it should be a different Jira (and maybe should cover
all cases that swallow exceptions).

Also: sorry for a) sending a review on the board for something that's probably too small,
and b) writing comments on my own review (intended to annotate, didn't realize it would appear
as if I were a separate reviewer).


Summary
-------

Fix for persistence of scan metrics when the scanner doesn't run to exhaustion.


This addresses bug HBASE-5717.
    https://issues.apache.org/jira/browse/HBASE-5717


Diffs (updated)
-----

  /src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java 1309585 
  /src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java 1309585 

Diff: https://reviews.apache.org/r/4640/diff


Testing
-------

Altered the scan metrics unit test to show this problem (now fails without changes to ClientScanner.java).


Thanks,

Ian


                
> Scanner metrics are only reported if you get to the end of a scanner
> --------------------------------------------------------------------
>
>                 Key: HBASE-5717
>                 URL: https://issues.apache.org/jira/browse/HBASE-5717
>             Project: HBase
>          Issue Type: Bug
>          Components: client, metrics
>            Reporter: Ian Varley
>            Priority: Minor
>         Attachments: ClientScanner_HBASE_5717-v2.patch, ClientScanner_HBASE_5717.patch
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> When you turn on Scanner Metrics, the metrics are currently only made available if you
run over all records available in the scanner. If you stop iterating before the end, the values
are never flushed into the metrics object (in the Scan attribute).
> Will supply a patch with fix and test.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message