hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5618) SplitLogManager - prevent unnecessary attempts to resubmits
Date Tue, 03 Apr 2012 16:30:25 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245466#comment-13245466
] 

Hadoop QA commented on HBASE-5618:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12520020/0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.master.TestSplitLogManager

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1377//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1377//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1377//console

This message is automatically generated.
                
> SplitLogManager - prevent unnecessary attempts to resubmits
> -----------------------------------------------------------
>
>                 Key: HBASE-5618
>                 URL: https://issues.apache.org/jira/browse/HBASE-5618
>             Project: HBase
>          Issue Type: Improvement
>          Components: wal, zookeeper
>            Reporter: Prakash Khemani
>         Attachments: 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch
>
>
> Currently once a watch fires that the task node has been updated (hearbeated) by the
worker, the splitlogmanager still quite some time before it updates the "last heard from"
time. This is because the manager currently schedules another getDataSetWatch() and only after
that finishes will it update the task's "last heard from" time.
> This leads to a large number of zk-BadVersion warnings when resubmission is continuously
attempted and it fails.
> Two changes should be made
> (1) On a resubmission failure because of BadVersion the task's lastUpdate time should
get upped.
> (2) The task's lastUpdate time should get upped as soon as the nodeDataChanged() watch
fires and without waiting for getDataSetWatch() to complete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message