hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk
Date Fri, 20 Apr 2012 01:30:41 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257965#comment-13257965
] 

Hadoop QA commented on HBASE-5824:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12523437/hbase_5824.addendum
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1588//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1588//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1588//console

This message is automatically generated.
                
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
>                 Key: HBASE-5824
>                 URL: https://issues.apache.org/jira/browse/HBASE-5824
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Elliott Clark
>            Assignee: Jimmy Xiang
>             Fix For: 0.96.0
>
>         Attachments: hbase-5824.patch, hbase-5824_v2.patch, hbase_5824.addendum
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue.
 On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same
thing over the wire so that the remote HRegionServer no longer knows which htable method was
called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and
then ran TestFromClientSide.  The breakpoint wasn't hit.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message