hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5788) Move Dynamic Metrics storage off of HRegion.
Date Tue, 17 Apr 2012 22:32:16 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256005#comment-13256005
] 

Hadoop QA commented on HBASE-5788:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12523008/HBASE-5788-4.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.replication.TestReplication

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1557//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1557//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1557//console

This message is automatically generated.
                
> Move Dynamic Metrics storage off of HRegion.
> --------------------------------------------
>
>                 Key: HBASE-5788
>                 URL: https://issues.apache.org/jira/browse/HBASE-5788
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>            Priority: Minor
>         Attachments: HBASE-5788-0.patch, HBASE-5788-1.patch, HBASE-5788-2.patch, HBASE-5788-3.patch,
HBASE-5788-4.patch
>
>
> HRegion right now has the responsibility of storing static counts and latency numbers
for use by the metrics package.  Since these maps are incremented and set from lots of places
it makes adding functionality hard.
>  
> So move the metrics functionality into SchemaMetrics making it more than just a class
for naming.  The next step will be to simplify the api exposed so that using it will be easier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message