hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hsieh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs
Date Mon, 23 Apr 2012 07:32:51 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259434#comment-13259434
] 

Jonathan Hsieh commented on HBASE-5654:
---------------------------------------

@Ashotosh - sorry for the delay on review.  Looks good.

I believe this isn't needed - looks like it was fixed in code.  I'll submit a new version
of the patch with this excluded and to get the new findbug numbers, and commit.

{code}
+ <Match>
+       <Class name="org.apache.hadoop.hbase.regionserver.StoreFile$Comparators$1"/>
+	   <Or>
+         <Method name="apply" />
+       </Or>
+       <Bug pattern="NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE" />
+     </Match>
{code}

                
> [findbugs] Address dodgy bugs
> -----------------------------
>
>                 Key: HBASE-5654
>                 URL: https://issues.apache.org/jira/browse/HBASE-5654
>             Project: HBase
>          Issue Type: Sub-task
>          Components: scripts
>    Affects Versions: 0.96.0
>            Reporter: Jonathan Hsieh
>            Assignee: Ashutosh Jindal
>              Labels: patch
>             Fix For: 0.96.0
>
>         Attachments: Hbase 5654_v3.patch, Hbase-5654.patch, Hbase_5654_V2.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_STYLE
> This may be broken down further.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message