hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5709) Move active master and backup master znodes to use pbs
Date Wed, 04 Apr 2012 15:23:39 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246358#comment-13246358

jiraposter@reviews.apache.org commented on HBASE-5709:

bq.  On 2012-04-04 00:21:57, Jimmy Xiang wrote:
bq.  > For ServerName, port and startcode are unassigned in pb, how do you handle those
-1 default values? For example, hbck uses -1 port.

Am I not creating a ServerName passing port and startcode?  This code  just does what the
old code does.  It did not intercept -1s, etc., so neither does this patch.

I think I'm not understanding.  Help me out.  Give it another go Jimmy.

- Michael

This is an automatically generated e-mail. To reply, visit:

On 2012-04-03 23:38:15, Michael Stack wrote:
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4630/
bq.  -----------------------------------------------------------
bq.  (Updated 2012-04-03 23:38:15)
bq.  Review request for hbase.
bq.  Summary
bq.  -------
bq.  Serialize active master using pb. Do same for backup masters.
bq.  D  src/main/java/org/apache/hadoop/hbase/MasterAddressTracker.java
bq.    Moved under zookeeper.  All other Trackers are under zookeeper but this one.
bq.  M  src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
bq.    Use new utility method for getting current master that is over in MasterAddressTracker.
bq.  M src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java
bq.    Move dup code out into a new handle function.
bq.    watcher.masterAddressZNode is no longer public. Use accessor.
bq.    Use new setMasterAddress,getMasterAddress function on
bq.    MasterAddressTracker for setting znode and backup master znode.
bq.  M src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java
bq.    Generated code.
bq.  M src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
bq.    Fix up import because MasterAddressTracker moved.
bq.  A src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java
bq.    Add back MasterAddressTracker here.  Add some utility functions for setting
bq.    and getting the master address.
bq.  M src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java
bq.    Move dataToServerName into ZKUtil.  Its useful beyond this class only.
bq.  M src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
bq.    Go via accessor to get master znode path and use new utility method
bq.    to get current master address.  dataToServerName moved here from
bq.    RootRegionTracker.
bq.  M src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
bq.    Shutdown access to masterAddressZNode.  Add an accessor method.
bq.  M  src/main/protobuf/ZooKeeper.proto
bq.    Add new master message class.
bq.  M src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java
bq.  M src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java
bq.    Go via new accessor and use utility over in MasterAddressTracker.
bq.  M src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java
bq.    Fix import to point at new location.
bq.  This addresses bug hbase-5709.
bq.      https://issues.apache.org/jira/browse/hbase-5709
bq.  Diffs
bq.  -----
bq.    src/main/java/org/apache/hadoop/hbase/MasterAddressTracker.java a246abe 
bq.    src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java aa30969 
bq.    src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java ef19cb9 
bq.    src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java 8ff87fe

bq.    src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 4f80999 
bq.    src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java PRE-CREATION

bq.    src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java 6b2ea57 
bq.    src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 037e354 
bq.    src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 0f83655 
bq.    src/main/protobuf/ZooKeeper.proto 20f8eb0 
bq.    src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java 05f6b1a 
bq.    src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java e91d83c

bq.    src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java 8478260

bq.  Diff: https://reviews.apache.org/r/4630/diff
bq.  Testing
bq.  -------
bq.  Thanks,
bq.  Michael

> Move active master and backup master znodes to use pbs
> ------------------------------------------------------
>                 Key: HBASE-5709
>                 URL: https://issues.apache.org/jira/browse/HBASE-5709
>             Project: HBase
>          Issue Type: Task
>            Reporter: stack
>            Assignee: stack
>         Attachments: 5709.txt

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message