hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings
Date Tue, 10 Apr 2012 19:13:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250969#comment-13250969
] 

jiraposter@reviews.apache.org commented on HBASE-5645:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4612/
-----------------------------------------------------------

(Updated 2012-04-10 19:11:48.808176)


Review request for hbase.


Changes
-------

Updated patch to work with trunk.  Fixed hanging test.  Ran test-patch.sh and -PrunAllTests.


Summary
-------

Fixes for issues reported in findbugs for "Correctness" category.


This addresses bug HBASE-5645.
    https://issues.apache.org/jira/browse/HBASE-5645


Diffs (updated)
-----

  dev-support/findHangingTest.sh 4518c68 
  dev-support/test-patch.properties 203df69 
  src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java c4a8a9e 
  src/main/java/org/apache/hadoop/hbase/mapreduce/CellCounter.java 63b2ed5 
  src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java de4b1e6 
  src/main/java/org/apache/hadoop/hbase/master/DefaultLoadBalancer.java 1676832 
  src/main/java/org/apache/hadoop/hbase/master/HMaster.java fb21bdd 
  src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 1c253a0 
  src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreLAB.java 2694897 
  src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.java 00f8d99 
  src/main/java/org/apache/hadoop/hbase/regionserver/Store.java bf1618e 
  src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 1636bfb 
  src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 698bb3d 
  src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java 545bd02

  src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java 62cf6ac 
  src/main/java/org/apache/hadoop/hbase/util/FSUtils.java aebe5b0 
  src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java c21377c 
  src/main/java/org/apache/hadoop/hbase/util/PoolMap.java 8e2a856 

Diff: https://reviews.apache.org/r/4612/diff


Testing
-------

Ran test-patch.sh and unit tests.


Thanks,

David


                
> [findbugs] Fix correctness warnings
> -----------------------------------
>
>                 Key: HBASE-5645
>                 URL: https://issues.apache.org/jira/browse/HBASE-5645
>             Project: HBase
>          Issue Type: Sub-task
>          Components: scripts
>            Reporter: Jonathan Hsieh
>            Assignee: David S. Wang
>         Attachments: HBASE-5645-2.patch, HBASE-5645.patch, HBASE-5645.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message