hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhihong Yu (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5702) MasterSchemaChangeTracker.excludeRegionServerForSchemaChanges leaks a MonitoredTask per call
Date Tue, 03 Apr 2012 16:58:24 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245496#comment-13245496
] 

Zhihong Yu commented on HBASE-5702:
-----------------------------------

The following method in ServerManager.java doesn't check the current value for hbase.instant.schema.alter.enabled
config:
{code}
  private void excludeRegionServerFromSchemaChanges(final ServerName serverName) {
    this.services.getSchemaChangeTracker()
        .excludeRegionServerForSchemaChanges(serverName.getServerName());
  }
{code}
                
> MasterSchemaChangeTracker.excludeRegionServerForSchemaChanges leaks a MonitoredTask per
call
> --------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5702
>                 URL: https://issues.apache.org/jira/browse/HBASE-5702
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.94.0
>            Reporter: Jean-Daniel Cryans
>            Priority: Critical
>             Fix For: 0.94.0, 0.96.0
>
>
> This bug is so easy to reproduce I'm wondering why it hasn't been reported yet. Stop
any number of region servers on a 0.94/6 cluster and you'll see in the master interface one
task per stopped region server saying the following:
> |Processing schema change exclusion for region server = sv4r27s44,62023,1333402175340|RUNNING
(since 5sec ago)|No schema change in progress. Skipping exclusion for server = sv4r27s44,62023,1333402175340
(since 5sec ago)|
> It's gonna stay there until the master cleans it:
> bq. WARN org.apache.hadoop.hbase.monitoring.TaskMonitor: Status Processing schema change
exclusion for region server = sv4r27s44,62023,1333402175340: status=No schema change in progress.
Skipping exclusion for server = sv4r27s44,62023,1333402175340, state=RUNNING, startTime=1333404636419,
completionTime=-1 appears to have been leaked
> It's not clear to me why it's using a MonitoredTask in the first place. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message