hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5733) AssignmentManager#processDeadServersAndRegionsInTransition can fail with NPE.
Date Tue, 17 Apr 2012 05:15:23 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255313#comment-13255313
] 

stack commented on HBASE-5733:
------------------------------

Patch looks good to me.  I like the test.  The LOG.fatal is redundant.  The master abort does
a log fatal.  Else patch is good.
                
> AssignmentManager#processDeadServersAndRegionsInTransition can fail with NPE.
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-5733
>                 URL: https://issues.apache.org/jira/browse/HBASE-5733
>             Project: HBase
>          Issue Type: Bug
>          Components: master
>    Affects Versions: 0.96.0
>            Reporter: Uma Maheswara Rao G
>            Assignee: Uma Maheswara Rao G
>         Attachments: HBASE-5733.patch, HBASE-5733.patch
>
>
> Found while going through the code...
> AssignmentManager#processDeadServersAndRegionsInTransition can fail with NPE as this
is directly iterating the nodes from listChildrenAndWatchForNewChildren with-out checking
for null.
> Here also we need to handle with  null  check like other places.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message