hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5045) Add the table name and cf name for the next call int the task monitor
Date Sat, 21 Apr 2012 01:27:35 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258722#comment-13258722

Phabricator commented on HBASE-5045:

tedyu has commented on the revision "[jira] [HBASE-5045] Annotation for Custom Param formatting
and next() RPC call info".

  WritableRpcEngine.java is going to be replaced in trunk. Would another issue be filed to
make this work with PB-based RPC ?

  All the catch clause should be on the same line as the preceding closing brace.

  src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java:193 'a RPC call' -> 'an RPC
  src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredTask.java:22 This import should
be after line 27.
  src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:3488 This should be package
  src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java:2217 Either return
res here or move line 2216 after this line.
  src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java:2206 '1 and 2 parameter'
-> '1-parameter and 2-parameter'
  src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java:2222 Can getOriginalScan()
be declared in RegionScanner ?
  It doesn't look nice referencing an implementation class.
  src/main/java/org/apache/hadoop/hbase/util/ParamFormat.java:2 No year is needed.
  src/main/java/org/apache/hadoop/hbase/util/ParamFormat.java:31 DEFAULT can be detailed,
right ?
  How about naming DEFAULT CONCISE ?
  src/main/java/org/apache/hadoop/hbase/util/ParamFormatHelper.java:2 No year, please.
  src/main/java/org/apache/hadoop/hbase/util/ParamFormatHelper.java:72 Insert a space after
  Put this on line 71.
  src/main/java/org/apache/hadoop/hbase/util/ParamFormatHelper.java:77 Put this on line 76.
  src/main/java/org/apache/hadoop/hbase/util/ParamFormatHelper.java:74 Insert a comma before
the space of " make sure"
  src/main/java/org/apache/hadoop/hbase/util/ParamFormatter.java:2 No year, please.
  src/test/java/org/apache/hadoop/hbase/util/TestParamFormatter.java:1 License, please.
  src/test/java/org/apache/hadoop/hbase/util/TestParamFormatter.java:16 Add test category.


> Add the table name and cf name for the next call int the task monitor
> ---------------------------------------------------------------------
>                 Key: HBASE-5045
>                 URL: https://issues.apache.org/jira/browse/HBASE-5045
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Liyin Tang
>            Assignee: Amir Shimoni
>         Attachments: D2913.1.patch, D2913.2.patch
> In the task monitor, we don't have much information about the next call compared to other
> It would be nice to add the table name and cf name for each next call in the task monitor.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message