Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 2 Mar 2012 19:54:02 +0000 (UTC)
From: "jiraposter@reviews.apache.org (Commented) (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <909282102.13616.1330718042188.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1732844274.3183.1329893334374.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-5444) Add PB-based calls to
 HMasterRegionInterface
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-5444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221209#comment-13221209 ] 

jiraposter@reviews.apache.org commented on HBASE-5444:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4149/#review5576
-----------------------------------------------------------


src/main/proto/HMasterRegionProtocol.proto
<https://reviews.apache.org/r/4149/#comment12076>

    will do.


src/main/proto/HMasterRegionProtocol.proto
<https://reviews.apache.org/r/4149/#comment12077>

    You can, the name here sucks -- this is really a MapEntry.  If you look at RegionServerStartupResponseProto, it contains a list of these entries.


src/main/proto/HMasterRegionProtocol.proto
<https://reviews.apache.org/r/4149/#comment12084>

    Good idea.  
    
    Not sure what the best form for comments is -- I don't see any way to have protobufs generate javadoc comments into the generated code.
    
    I'll figure something out.


- Gregory


On 2012-03-02 01:30:36, Gregory Chanan wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4149/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-03-02 01:30:36)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Protobuf work for HMasterRegionInterface.
bq.  
bq.  No need to comment on the pom.xml changes: I just copied those from HBASE-5443 (https://reviews.apache.org/r/4054/).
bq.  
bq.  
bq.  This addresses bug HBASE-5444.
bq.      https://issues.apache.org/jira/browse/HBASE-5444
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    pom.xml 0f0aa9a 
bq.    src/main/proto/HMasterRegionProtocol.proto PRE-CREATION 
bq.    src/main/proto/hbase.proto PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/4149/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  mvn -DskipTests package successful and files generated successfully
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Gregory
bq.  
bq.


> Add PB-based calls to HMasterRegionInterface
> --------------------------------------------
>
>                 Key: HBASE-5444
>                 URL: https://issues.apache.org/jira/browse/HBASE-5444
>             Project: HBase
>          Issue Type: Sub-task
>          Components: ipc, master, migration, regionserver
>            Reporter: Todd Lipcon
>            Assignee: Gregory Chanan
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira