Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 22 Mar 2012 21:28:22 +0000 (UTC)
From: "Zhihong Yu (Commented) (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <837522275.4699.1332451702688.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <631239917.8345.1331656123975.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-5573) Replace client ZooKeeper watchers
 by simple ZooKeeper reads
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-5573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236053#comment-13236053 ] 

Zhihong Yu commented on HBASE-5573:
-----------------------------------

The failed test was due to OOME.
Patch v6 looks good.
{code}
+        }finally {
+          zkw.close();
{code}
Please insert a space between } and finally.

Run 'arc lint' to see all formatting warnings.
                
> Replace client ZooKeeper watchers by simple ZooKeeper reads
> -----------------------------------------------------------
>
>                 Key: HBASE-5573
>                 URL: https://issues.apache.org/jira/browse/HBASE-5573
>             Project: HBase
>          Issue Type: Improvement
>          Components: client, zookeeper
>    Affects Versions: 0.96.0
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>         Attachments: 5573.v1.patch, 5573.v2.patch, 5573.v4.patch, 5573.v6.patch
>
>
> Some code in the package needs to read data in ZK. This could be done by a simple read, but is actually implemented with a watcher. This holds ZK resources.
> Fixing this could also be an opportunity to remove the need for the client to provide the master address and port.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira