Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 23 Mar 2012 05:42:22 +0000 (UTC)
From: "chunhui shen (Commented) (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <665039324.6715.1332481342703.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1949871657.6589.1332478944224.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-5624) Aborting regionserver when
 splitting region, may cause daughter region not assigned by
 ServerShutdownHandler.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-5624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236356#comment-13236356 ] 

chunhui shen commented on HBASE-5624:
-------------------------------------

@stack
Yes, if cluster is all going down, master will assign region whose location is null when cluster is started up.

However, if only one rs is stoped( or aborted by exception), master proceess it as dead server by ServerShutdownHandler, and the daughter regions whose location are null will not be assigned.
                
> Aborting regionserver when splitting region, may cause daughter region not assigned by ServerShutdownHandler.
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5624
>                 URL: https://issues.apache.org/jira/browse/HBASE-5624
>             Project: HBase
>          Issue Type: Bug
>            Reporter: chunhui shen
>            Assignee: chunhui shen
>         Attachments: HBASE-5624.patch
>
>
> If one region is splitting when regionserver is stoping.
> The following code may executed in SplitTransaction#openDaughters.
> {code}
> // TODO: Is this check needed here?
>     if (stopped || stopping) {
>       // add 2nd daughter first (see HBASE-4335)
>       MetaEditor.addDaughter(server.getCatalogTracker(),
>           b.getRegionInfo(), null);
>       MetaEditor.addDaughter(server.getCatalogTracker(),
>           a.getRegionInfo(), null);
>       LOG.info("Not opening daughters " +
>           b.getRegionInfo().getRegionNameAsString() +
>           " and " +
>           a.getRegionInfo().getRegionNameAsString() +
>           " because stopping=" + stopping + ", stopped=" + stopped);
>     } 
> {code}
> So, for the two daughter regions, their location are both null in .META.
> When ServerShutdownHandler process the dead server, it will not assign these two daughter regions since their location(info:server) are null in .META. by MetaReader.getServerUserRegions().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira