Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 08CA59313 for ; Tue, 6 Mar 2012 18:13:19 +0000 (UTC) Received: (qmail 81059 invoked by uid 500); 6 Mar 2012 18:13:18 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 80922 invoked by uid 500); 6 Mar 2012 18:13:18 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 80901 invoked by uid 99); 6 Mar 2012 18:13:18 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Mar 2012 18:13:18 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Mar 2012 18:13:17 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 82DA0B90D for ; Tue, 6 Mar 2012 18:12:57 +0000 (UTC) Date: Tue, 6 Mar 2012 18:12:57 +0000 (UTC) From: "Mikhail Bautin (Commented) (JIRA)" To: issues@hbase.apache.org Message-ID: <628972481.28418.1331057577537.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <905435482.2196.1323716970795.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HBASE-5010) Filter HFiles based on TTL MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HBASE-5010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223490#comment-13223490 ] Mikhail Bautin commented on HBASE-5010: --------------------------------------- @Ram: I don't see any mentions of HBASE-5510 in this JIRA, except for your comment. What updates are you referring to? > Filter HFiles based on TTL > -------------------------- > > Key: HBASE-5010 > URL: https://issues.apache.org/jira/browse/HBASE-5010 > Project: HBase > Issue Type: Bug > Reporter: Mikhail Bautin > Assignee: Mikhail Bautin > Fix For: 0.94.0 > > Attachments: 5010.patch, D1017.1.patch, D1017.2.patch, D909.1.patch, D909.2.patch, D909.3.patch, D909.4.patch, D909.5.patch, D909.6.patch > > > In ScanWildcardColumnTracker we have > {code:java} > > this.oldestStamp = EnvironmentEdgeManager.currentTimeMillis() - ttl; > ... > private boolean isExpired(long timestamp) { > return timestamp < oldestStamp; > } > {code} > but this time range filtering does not participate in HFile selection. In one real case this caused next() calls to time out because all KVs in a table got expired, but next() had to iterate over the whole table to find that out. We should be able to filter out those HFiles right away. I think a reasonable approach is to add a "default timerange filter" to every scan for a CF with a finite TTL and utilize existing filtering in StoreFile.Reader.passesTimerangeFilter. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira