Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 8 Mar 2012 18:32:00 +0000 (UTC)
From: "jiraposter@reviews.apache.org (Commented) (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <520096970.39621.1331231520356.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <906306925.25361.1330997396951.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-5526) Configurable file and directory
 based umask
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-5526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225368#comment-13225368 ] 

jiraposter@reviews.apache.org commented on HBASE-5526:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4217/
-----------------------------------------------------------

(Updated 2012-03-08 18:31:13.452976)


Review request for hbase and Lars Hofhansl.


Changes
-------

New patch addressing Ted and Lars' comments. Thanks guys!


Summary
-------

Currently many all the files created by the HBase user are just written using the default file permissions granted by hdfs. However, to ensure only the correct user/group views the files and directories, we need to be able to apply a configurable umask to either directories or files.

This ticket covers setting permissions for files written to dfs, as opposed to things like pid and log files.

The impetus for this was to allow the web-user to view the directory structure of hbase, but not to actually see any of the actual data hbase is storing.


This addresses bug HBASE-5526.
    https://issues.apache.org/jira/browse/HBASE-5526


Diffs (updated)
-----

  src/main/java/org/apache/hadoop/hbase/HConstants.java e60ce04 
  src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileWriter.java 9e7e624 
  src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 76ff422 
  src/main/java/org/apache/hadoop/hbase/util/FSUtils.java d2d7efe 
  src/main/resources/hbase-default.xml 9277e0c 
  src/test/java/org/apache/hadoop/hbase/util/TestFSUtils.java e2611e6 

Diff: https://reviews.apache.org/r/4217/diff


Testing
-------

"mvn clean test -P localTests" passes


Thanks,

Jesse


> Configurable file and directory based umask
> -------------------------------------------
>
>                 Key: HBASE-5526
>                 URL: https://issues.apache.org/jira/browse/HBASE-5526
>             Project: HBase
>          Issue Type: New Feature
>          Components: regionserver
>            Reporter: Jesse Yates
>            Assignee: Jesse Yates
>             Fix For: 0.94.0
>
>         Attachments: java_HBASE-5526-v2.patch, java_HBASE-5526-v3.patch, java_HBASE-5526.patch
>
>
> Currently many all the files created by the HBase user are just written using the default file permissions granted by hdfs. However, to ensure only the correct user/group views the files and directories, we need to be able to apply a configurable umask to either directories or files. 
> This ticket covers setting permissions for files written to dfs, as opposed to things like pid and log files.
> The impetus for this was to allow the web-user to view the directory structure of hbase, but not to actually see any of the actual data hbase is storing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira