Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 23 Mar 2012 08:17:42 +0000 (UTC)
From: "jiraposter@reviews.apache.org (Commented) (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <454010215.7176.1332490662513.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-3134) [replication] Add the ability to
 enable/disable streams
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-3134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236450#comment-13236450 ] 

jiraposter@reviews.apache.org commented on HBASE-3134:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3686/
-----------------------------------------------------------

(Updated 2012-03-23 08:16:47.333041)


Review request for hbase.


Changes
-------

This update addresses the issue found by J-D.
A new test which fails without the modification to the shipEdits() is added to the TestReplication.


Summary
-------

1. The patch introduces a znode which represents whether a peer is enabled or not. ReplicationSource skips sending entries if the replication is disabled.
2. The "list_peers" shows state of each peer and support for {enable|disable}Peer is added.


This addresses bug HBASE-3134.
    https://issues.apache.org/jira/browse/HBASE-3134


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationAdmin.java 1304172 
  http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeer.java 1304190 
  http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeper.java 1304190 
  http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java 1304190 
  http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceInterface.java 1304190 
  http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java 1304190 
  http://svn.apache.org/repos/asf/hbase/trunk/src/main/ruby/hbase/replication_admin.rb 1304172 
  http://svn.apache.org/repos/asf/hbase/trunk/src/main/ruby/shell/commands/disable_peer.rb 1304172 
  http://svn.apache.org/repos/asf/hbase/trunk/src/main/ruby/shell/commands/enable_peer.rb 1304172 
  http://svn.apache.org/repos/asf/hbase/trunk/src/main/ruby/shell/commands/list_peers.rb 1304172 
  http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/replication/ReplicationSourceDummy.java 1304172 
  http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java 1304172 
  http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSourceManager.java 1304172 

Diff: https://reviews.apache.org/r/3686/diff


Testing
-------

1. TestReplication passed.
2. Checked on a cluster with some updates (puts) from shell.


Thanks,

Teruyoshi


> [replication] Add the ability to enable/disable streams
> -------------------------------------------------------
>
>                 Key: HBASE-3134
>                 URL: https://issues.apache.org/jira/browse/HBASE-3134
>             Project: HBase
>          Issue Type: New Feature
>          Components: replication
>            Reporter: Jean-Daniel Cryans
>            Assignee: Teruyoshi Zenmyo
>            Priority: Minor
>              Labels: replication
>             Fix For: 0.94.1
>
>         Attachments: 3134-v2.txt, 3134-v3.txt, 3134.txt, HBASE-3134.patch, HBASE-3134.patch, HBASE-3134.patch, HBASE-3134.patch
>
>
> This jira was initially in the scope of HBASE-2201, but was pushed out since it has low value compared to the required effort (and when want to ship 0.90.0 rather soonish).
> We need to design a way to enable/disable replication streams in a determinate fashion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira