Return-Path: 
 <issues-return-41115-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 1AE0895CD
	for <apmail-hbase-issues-archive@www.apache.org>;
 Tue, 27 Mar 2012 17:52:50 +0000 (UTC)
Received: (qmail 72704 invoked by uid 500); 27 Mar 2012 17:52:48 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 72665 invoked by uid 500); 27 Mar 2012 17:52:48 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 72609 invoked by uid 99); 27 Mar 2012 17:52:48 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Mar 2012 17:52:48 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=5.0
	tests=ALL_TRUSTED,T_RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Mar 2012 17:52:47 +0000
Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116])
	by hel.zones.apache.org (Postfix) with ESMTP id 803CF349005
	for <issues@hbase.apache.org>; Tue, 27 Mar 2012 17:52:27 +0000 (UTC)
Date: Tue, 27 Mar 2012 17:52:27 +0000 (UTC)
From: "Zhihong Yu (Commented) (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <339387638.24475.1332870747534.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <869320306.16749.1332755847079.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-5635) If getTaskList() returns null
 splitlogWorker is down. It wont serve any requests.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/HBASE-5635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239723#comment-13239723 ] 

Zhihong Yu commented on HBASE-5635:
-----------------------------------

Please change the wording in the following log:
{code}
+        LOG.warn("Could not get tasks, did someone remove "
+            + this.watcher.splitLogZNode + " ... worker thread exiting.");
{code}
In this case the worker thread is not exiting.
                
> If getTaskList() returns null splitlogWorker is down. It wont serve any requests. 
> ----------------------------------------------------------------------------------
>
>                 Key: HBASE-5635
>                 URL: https://issues.apache.org/jira/browse/HBASE-5635
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>    Affects Versions: 0.92.1
>            Reporter: Kristam Subba Swathi
>         Attachments: HBASE-5635.patch
>
>
> During the hlog split operation if all the zookeepers are down ,then the paths will be returned as null and the splitworker thread wil be exited
> Now this regionserver wil not be able to acquire any other tasks since the splitworker thread is exited
> Please find the attached code for more details
> {code}
> private List<String> getTaskList() {
>     for (int i = 0; i < zkretries; i++) {
>       try {
>         return (ZKUtil.listChildrenAndWatchForNewChildren(this.watcher,
>             this.watcher.splitLogZNode));
>       } catch (KeeperException e) {
>         LOG.warn("Could not get children of znode " +
>             this.watcher.splitLogZNode, e);
>         try {
>           Thread.sleep(1000);
>         } catch (InterruptedException e1) {
>           LOG.warn("Interrupted while trying to get task list ...", e1);
>           Thread.currentThread().interrupt();
>           return null;
>         }
>       }
>     }
> {code}
> in the org.apache.hadoop.hbase.regionserver.SplitLogWorker 
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira