Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 21 Mar 2012 23:18:24 +0000 (UTC)
From: "jiraposter@reviews.apache.org (Commented) (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <2107881063.2.1332371904348.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <727713864.6682.1328251674038.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-5328) Small changes to Master to make it
 more testable
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-5328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235180#comment-13235180 ] 

jiraposter@reviews.apache.org commented on HBASE-5328:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4436/#review6195
-----------------------------------------------------------


Addressed the comments.  Going to commit.


src/main/java/org/apache/hadoop/hbase/master/HMaster.java
<https://reviews.apache.org/r/4436/#comment13350>

    Changed it though this not my change.  I just moved this log into a method.


src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java
<https://reviews.apache.org/r/4436/#comment13351>

    No.  Its a protected method in a test!


src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java
<https://reviews.apache.org/r/4436/#comment13352>

    No.  Makes it obvious they are not default behavior.


- Michael


On 2012-03-21 19:50:51, Michael Stack wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4436/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-03-21 19:50:51)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  M src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java
bq.    Make this class public so its waitForRoot(long) can be used by HMaster.
bq.    Remove the stalling waitForRoot no arg.
bq.  M src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
bq.    Javadoc.  Add check if stopped flag cycling waiting on assignment.
bq.  M src/main/java/org/apache/hadoop/hbase/master/HMaster.java
bq.    Moved check if schema change flag out to a method rather than
bq.    have it on tail of constructor.
bq.    Moved other initialization stuff like get of assignment manager
bq.    and server manager out into methods so could be intercepted by
bq.    tests and mocking.
bq.    Change how we wait on root so we sleep 100ms at a time and always
bq.    check stopped flag rather than block for ever.
bq.    Added more checking if stopped flag.
bq.    Added flag for when rpc server is up, mostly for tests.
bq.  M src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java
bq.    Unused import.
bq.  M src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
bq.    Comment.
bq.  M src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
bq.    Remove unused code.
bq.  M src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java
bq.    Change how we wait on root.  DOn't use removed method.
bq.  A src/test/java/org/apache/hadoop/hbase/master/MockRegionS
bq.  
bq.  
bq.  This addresses bug hbase-5328.
bq.      https://issues.apache.org/jira/browse/hbase-5328
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 79b6604 
bq.    src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java 90fa45a 
bq.    src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java PRE-CREATION 
bq.    src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 7f97b01 
bq.    src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java a929e31 
bq.    src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java d47ef10 
bq.    src/main/java/org/apache/hadoop/hbase/master/HMaster.java 0d7cbeb 
bq.    src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java beaff97 
bq.    src/test/java/org/apache/hadoop/hbase/master/Mocking.java PRE-CREATION 
bq.    src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java 841649a 
bq.    src/test/java/org/apache/hadoop/hbase/master/TestMasterNoCluster.java PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/4436/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Michael
bq.  
bq.


> Small changes to Master to make it more testable
> ------------------------------------------------
>
>                 Key: HBASE-5328
>                 URL: https://issues.apache.org/jira/browse/HBASE-5328
>             Project: HBase
>          Issue Type: Task
>            Reporter: stack
>            Assignee: stack
>         Attachments: 5328.txt, 5328v2.txt, 5328v2.txt, 5328v3.txt, 5328v4.txt
>
>
> Here are some small changes in Master that make it more testable.  Included tests stand up a Master and then fake it into thinking that three regionservers are registering making master assign root and meta, etc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira