Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4ED73988E for ; Fri, 23 Mar 2012 19:57:54 +0000 (UTC) Received: (qmail 84971 invoked by uid 500); 23 Mar 2012 19:57:54 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 84932 invoked by uid 500); 23 Mar 2012 19:57:54 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 84920 invoked by uid 99); 23 Mar 2012 19:57:54 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Mar 2012 19:57:54 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Mar 2012 19:57:49 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 4F5DE343822 for ; Fri, 23 Mar 2012 19:57:29 +0000 (UTC) Date: Fri, 23 Mar 2012 19:57:29 +0000 (UTC) From: "jiraposter@reviews.apache.org (Commented) (JIRA)" To: issues@hbase.apache.org Message-ID: <2090919456.9971.1332532649327.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1732844274.3183.1329893334374.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HBASE-5444) Add PB-based calls to HMasterRegionInterface MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HBASE-5444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236999#comment-13236999 ] jiraposter@reviews.apache.org commented on HBASE-5444: ------------------------------------------------------ ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4463/ ----------------------------------------------------------- (Updated 2012-03-23 19:55:28.089163) Review request for hbase. Changes ------- Update for Jimmy's review. Summary ------- Adds PB-based calls replacing HMasterRegionInterface. There are some temporary hacks, e.g. converting PB-based ServerLoad to existing HServerLoad so I didn't need to convert ClusterStatus (which brings in a lot of other changes). That will be cleaned up in HBASE-5445. This addresses bug HBASE-5444. https://issues.apache.org/jira/browse/HBASE-5444 Diffs (updated) ----- pom.xml 10b13ef src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon 69434f7 src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon ae76204 src/main/java/org/apache/hadoop/hbase/ClusterStatus.java 9df4c10 src/main/java/org/apache/hadoop/hbase/HConstants.java 8888347 src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java cbfa489 src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java 0db2760 src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java 2916d68 src/main/java/org/apache/hadoop/hbase/ipc/HMasterRegionInterface.java fd97830 src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java f1f06b0 src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java d47ef10 src/main/java/org/apache/hadoop/hbase/master/HMaster.java cd1755f src/main/java/org/apache/hadoop/hbase/master/MXBean.java 7f44dc2 src/main/java/org/apache/hadoop/hbase/master/MXBeanImpl.java 45b8fe7 src/main/java/org/apache/hadoop/hbase/master/MasterDumpServlet.java be63838 src/main/java/org/apache/hadoop/hbase/master/ServerManager.java cbd55f7 src/main/java/org/apache/hadoop/hbase/protobuf/MasterRegionInterface.java PRE-CREATION src/main/java/org/apache/hadoop/hbase/protobuf/PBHelper.java PRE-CREATION src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java e0af8fb src/main/proto/MasterRegionProtocol.proto PRE-CREATION src/main/proto/hbase.proto PRE-CREATION src/main/resources/hbase-webapps/master/table.jsp 811df46 src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java 6af9188 src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 368a0e5 src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java f2f8ee3 src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java 841649a src/test/java/org/apache/hadoop/hbase/master/TestMXBean.java 379f70c src/test/java/org/apache/hadoop/hbase/regionserver/TestServerCustomProtocol.java e99d251 Diff: https://reviews.apache.org/r/4463/diff Testing ------- Ran jenkins job, all unit tests passed. Thanks, Gregory > Add PB-based calls to HMasterRegionInterface > -------------------------------------------- > > Key: HBASE-5444 > URL: https://issues.apache.org/jira/browse/HBASE-5444 > Project: HBase > Issue Type: Sub-task > Components: ipc, master, migration, regionserver > Reporter: Todd Lipcon > Assignee: Gregory Chanan > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira