Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 26 Mar 2012 22:38:28 +0000 (UTC)
From: "Uma Maheswara Rao G (Commented) (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <2056644898.20088.1332801508300.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <934354298.28753.1332035200103.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-5598) Analyse and fix the findbugs
 reporting by QA and add invalid bugs into findbugs-excludeFilter file
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238924#comment-13238924 ] 

Uma Maheswara Rao G commented on HBASE-5598:
--------------------------------------------

As a initial start I updated the patch with filter file.

1) added filter file
2) excluded generated packges.
   org.apache.hadoop.hbase.thrift2.generated, org.apache.hadoop.hbase.thrift.generated, org.apache.hadoop.hbase.rest.protobuf.generated

This reduces the findbugs count from 772 to 601.

{quote}
[WARNING]
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building HBase 0.95-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- findbugs-maven-plugin:2.4.0:findbugs (default-cli) @ hbase ---
[INFO] Fork Value is true
     [java] Warnings generated: 601
[INFO] Done FindBugs Analysis....
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 3:19.270s
[INFO] Finished at: Tue Mar 27 03:56:20 IST 2012
[INFO] Final Memory: 13M/55M
[INFO] ------------------------------------------------------------------------
{quote}

note: currently we have already increased the count of findbugs in test-patch.properties. While verifying, I just reverted back to 0 for testing.

                
> Analyse and fix the findbugs reporting by QA and add invalid bugs into findbugs-excludeFilter file
> --------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5598
>                 URL: https://issues.apache.org/jira/browse/HBASE-5598
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.92.1, 0.94.0, 0.96.0
>            Reporter: Uma Maheswara Rao G
>            Assignee: Uma Maheswara Rao G
>            Priority: Minor
>         Attachments: HBASE-5598.patch
>
>
> There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to up the OK count.
> This may lead to other issues when we re-factor the code, if we induce new valid ones and remove invalid bugs also can not be reported by QA.
> So, I would propose to add the exclude filter file for findbugs(for the invalid bugs). If we find any valid ones, we can fix under this JIRA.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira