Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5444E9181 for ; Tue, 6 Mar 2012 07:01:25 +0000 (UTC) Received: (qmail 47904 invoked by uid 500); 6 Mar 2012 07:01:24 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 47676 invoked by uid 500); 6 Mar 2012 07:01:21 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 47651 invoked by uid 99); 6 Mar 2012 07:01:20 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Mar 2012 07:01:20 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Mar 2012 07:01:19 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 75E2DA5B5 for ; Tue, 6 Mar 2012 07:00:59 +0000 (UTC) Date: Tue, 6 Mar 2012 07:00:59 +0000 (UTC) From: "Benoit Sigoure (Commented) (JIRA)" To: issues@hbase.apache.org Message-ID: <1758498079.26259.1331017259484.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1572629906.25944.1331005261940.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HBASE-5527) PerformanceEvaluation: Report aggregate timings on a single line MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HBASE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223040#comment-13223040 ] Benoit Sigoure commented on HBASE-5527: --------------------------------------- Lars, I'm using {{nanoTime}} because it's the recommended way to measure time in benchmarks. It uses the most accurate monotonically increasing counter the CPU has. System time can change due to NTP adjusting the clock, leap seconds etc. > PerformanceEvaluation: Report aggregate timings on a single line > ---------------------------------------------------------------- > > Key: HBASE-5527 > URL: https://issues.apache.org/jira/browse/HBASE-5527 > Project: HBase > Issue Type: Improvement > Components: performance > Affects Versions: 0.92.0 > Reporter: Benoit Sigoure > Assignee: Benoit Sigoure > Priority: Minor > Attachments: 0001-PerformanceEvaluation-fixes.patch, 0001-PerformanceEvaluation-fixes.patch > > > When running {{PerformanceEvaluation}} with {{--nomapred}} it's hard to locate all the lines saying {{Finished 14 in 292979ms writing 2000000 rows}} in the output. This change adds a couples line to summarize the run at the end, which makes parsing and scripting the output easier: > {code} > 12/03/06 00:43:58 INFO hbase.PerformanceEvaluation: [RandomWriteTest] Summary of timings (ms): [15940, 15776, 15866, 15973, 15682, 15740, 15764, 15830, 15768, 15968, 15921, 15755, 15963, 15818, 15903, 15662] > 12/03/06 00:43:58 INFO hbase.PerformanceEvaluation: [RandomWriteTest] Min: 15662ms Max: 15973ms Avg: 15833ms > {code} > Patch also removes a couple minor code smells. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira