Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AB8E89A1D for ; Wed, 21 Mar 2012 05:40:06 +0000 (UTC) Received: (qmail 57000 invoked by uid 500); 21 Mar 2012 05:40:06 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 56935 invoked by uid 500); 21 Mar 2012 05:40:06 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 56911 invoked by uid 99); 21 Mar 2012 05:40:06 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Mar 2012 05:40:06 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Mar 2012 05:40:04 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id E2481CE892 for ; Wed, 21 Mar 2012 05:39:44 +0000 (UTC) Date: Wed, 21 Mar 2012 05:39:44 +0000 (UTC) From: "ramkrishna.s.vasudevan (Updated) (JIRA)" To: issues@hbase.apache.org Message-ID: <1508575100.40397.1332308384955.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <825356208.18943.1331817577706.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (HBASE-5584) Coprocessor hooks can be called in the respective handlers MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HBASE-5584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-5584: ------------------------------------------ Attachment: HBASE-5584-1.patch Updated patch. In my local it was passing. Now added some sleep after create so that we can ensure that the postCreateHandler is called. Pls review. > Coprocessor hooks can be called in the respective handlers > ---------------------------------------------------------- > > Key: HBASE-5584 > URL: https://issues.apache.org/jira/browse/HBASE-5584 > Project: HBase > Issue Type: Improvement > Components: coprocessors > Reporter: ramkrishna.s.vasudevan > Assignee: ramkrishna.s.vasudevan > Fix For: 0.96.0 > > Attachments: HBASE-5584-1.patch, HBASE-5584.patch > > > Following points can be changed w.r.t to coprocessors > -> Call preCreate, postCreate, preEnable, postEnable, etc. in their respective handlers > -> Currently it is called in the HMaster thus making the postApis async w.r.t the handlers > -> Similar is the case with the balancer. > with current behaviour once we are in the postEnable(for eg) we any way need to wait for the main enable handler to > be completed. > We should ensure that we dont wait in the main thread so again we need to spawn a thread and wait on that. > On the other hand if the pre and post api is called on the handlers then only that handler thread will be > used in the pre/post apis > If the above said plan is ok i can prepare a patch for all such related changes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira