Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 27 Mar 2012 17:22:26 +0000 (UTC)
From: "Lars Hofhansl (Commented) (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <1224030359.24199.1332868946766.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <467826969.20320.1332803547880.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-5639) The logic used in waiting for
 region servers during startup is broken
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-5639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239661#comment-13239661 ] 

Lars Hofhansl commented on HBASE-5639:
--------------------------------------

Ready for commit? I'm happy to commit, since I'd have to update CHANGES.txt as well (as this will be an RC candidate build).
                
> The logic used in waiting for region servers during startup is broken
> ---------------------------------------------------------------------
>
>                 Key: HBASE-5639
>                 URL: https://issues.apache.org/jira/browse/HBASE-5639
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>            Assignee: nkeywal
>            Priority: Blocker
>             Fix For: 0.94.0
>
>         Attachments: HBASE-5639.patch
>
>
> See the tail of HBASE-4993, which I'll report here:
> Me:
> {quote}
> I think a bug was introduced here. Here's the new waiting logic in waitForRegionServers:
> the 'hbase.master.wait.on.regionservers.mintostart' is reached AND
>    there have been no new region server in for
>       'hbase.master.wait.on.regionservers.interval' time
> And the code that verifies that:
> !(lastCountChange+interval > now && count >= minToStart)
> {quote}
> Nic:
> {quote}
> It seems that changing the code to
> (count < minToStart ||
> lastCountChange+interval > now)
> would make the code works as documented.
> If you have 0 region servers that checked in and you are under the interval, you wait: (true or true) = true.
> If you have 0 region servers but you are above the interval, you wait: (true or false) = true.
> If you have 1 or more region servers that checked in and you are under the interval, you wait: (false or true) = true.
> {quote}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira