hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhihong Yu (Issue Comment Edited) (JIRA)" <j...@apache.org>
Subject [jira] [Issue Comment Edited] (HBASE-5512) Add support for INCLUDE_AND_SEEK_USING_HINT
Date Sun, 04 Mar 2012 15:45:59 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221915#comment-13221915
] 

Zhihong Yu edited comment on HBASE-5512 at 3/4/12 3:45 PM:
-----------------------------------------------------------

CustomIncludeAndNextUsingHintFilter.java misses license and class javadoc.
In ScanQueryMatcher.java:
{code}
+    boolean filterSeek = false;
{code}
Can the above variable be named such that the name reflects semantics for INCLUDE_AND_NEXT_USING_HINT
?
That would make understanding the following code easier:
{code}
+    if (filterSeek) {
+      switch(colChecker) {
+      case INCLUDE:
{code}
                
      was (Author: zhihyu@ebaysf.com):
    CustomIncludeAndNextUsingHintFilter.java misses license and class javadoc.
{code}
+    boolean filterSeek = false;
{code}
Can the above variable be named such that the name reflects semantics for INCLUDE_AND_NEXT_USING_HINT
?
That would make understanding the following code easier:
{code}
+    if (filterSeek) {
+      switch(colChecker) {
+      case INCLUDE:
{code}
                  
> Add support for INCLUDE_AND_SEEK_USING_HINT
> -------------------------------------------
>
>                 Key: HBASE-5512
>                 URL: https://issues.apache.org/jira/browse/HBASE-5512
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Zhihong Yu
>            Assignee: Lars Hofhansl
>         Attachments: 5512-v2.txt, 5512.txt
>
>
> This came up from HBASE-2038
> From Anoop:
> - What we wanted from the filter is include a row and then seek to the next row which
we are interested in. I cant see such a facility with our Filter right now. Correct me if
I am wrong. So suppose we already seeked to one row and this need to be included in the result,
then the Filter should return INCLUDE. Then when the next next() call happens, then only we
can return a SEEK_USING_HINT. So one extra row reading is needed. This might create even one
unwanted HFileBlock fetch (who knows).
> Can we add reseek() at higher level?
> From Lars:
> Yep, for that we'd need to add INCLUDE_AND_SEEK_USING_HINT (similar to the INCLUDE_AND_SEEK_NEXT_ROW
that we already have). Shouldn't be hard to add, I'm happy to do that, if that's the route
we want to go with this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message