hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Hofhansl (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5527) PerformanceEvaluation: Report aggregate timings on a single line
Date Tue, 06 Mar 2012 06:39:07 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223028#comment-13223028
] 

Lars Hofhansl commented on HBASE-5527:
--------------------------------------

Looks good.
Why use nanoTime here, when it is scaled back milliseconds in the end anyway?
{code}
+      final long startTime = System.nanoTime();
...
+      return (System.nanoTime() - startTime) / 1000000;
{code}

                
> PerformanceEvaluation: Report aggregate timings on a single line
> ----------------------------------------------------------------
>
>                 Key: HBASE-5527
>                 URL: https://issues.apache.org/jira/browse/HBASE-5527
>             Project: HBase
>          Issue Type: Improvement
>          Components: performance
>    Affects Versions: 0.92.0
>            Reporter: Benoit Sigoure
>            Assignee: Benoit Sigoure
>            Priority: Minor
>         Attachments: 0001-PerformanceEvaluation-fixes.patch
>
>
> When running {{PerformanceEvaluation}} with {{--nomapred}} it's hard to locate all the
lines saying {{Finished 14 in 292979ms writing 2000000 rows}} in the output.  This change
adds a couples line to summarize the run at the end, which makes parsing and scripting the
output easier:
> {code}
> 12/03/06 00:43:58 INFO hbase.PerformanceEvaluation: [RandomWriteTest] Summary of timings
(ms): [15940, 15776, 15866, 15973, 15682, 15740, 15764, 15830, 15768, 15968, 15921, 15755,
15963, 15818, 15903, 15662]
> 12/03/06 00:43:58 INFO hbase.PerformanceEvaluation: [RandomWriteTest]	Min: 15662ms	Max:
15973ms	Avg: 15833ms
> {code}
> Patch also removes a couple minor code smells.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message