hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5619) Create PB protocols for HRegionInterface
Date Tue, 27 Mar 2012 20:46:29 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239935#comment-13239935
] 

jiraposter@reviews.apache.org commented on HBASE-5619:
------------------------------------------------------



bq.  On 2012-03-26 23:21:58, Michael Stack wrote:
bq.  > src/main/proto/RegionClient.proto, line 193
bq.  > <https://reviews.apache.org/r/4054/diff/5/?file=95916#file95916line193>
bq.  >
bq.  >     What is this implementing from current Delete?  The delete family?
bq.  >     
bq.  >     This is returned to the client?
bq.  >     
bq.  >     How do we do a column that has no qualifier?  Thats possible in hbase.
bq.  
bq.  Jimmy Xiang wrote:
bq.      To delete a family, you don't specify the qualifier. To delete a only one version
of a column, you sepcify the family, qualifer, timestamp, and set oneVersion to true.
bq.      To delete all version of a column, you specify the family, qualifier
bq.      
bq.      What do you mean a column that has no qualifier? Are you referring to Delete.deleteColumns(family,
qualifier, timestamp), and qualifer = null?
bq.  
bq.  Michael Stack wrote:
bq.      Yeah.  You can put a value at row, family, null qualifier, ts. You can also delete
it (might not be a good idea but you can do it).
bq.  
bq.  Jimmy Xiang wrote:
bq.      In this case, all columns in the family for this row will be deleted, right?
bq.  
bq.  Michael Stack wrote:
bq.      IIRC, yes.  See http://hbase.apache.org/book.html#delete where I tried to doc the
options

I see.  Will cover this scenario.


bq.  On 2012-03-26 23:21:58, Michael Stack wrote:
bq.  > src/main/proto/RegionClient.proto, line 84
bq.  > <https://reviews.apache.org/r/4054/diff/5/?file=95916#file95916line84>
bq.  >
bq.  >     Why is the Get polluted by multiGet stuff?
bq.  
bq.  Jimmy Xiang wrote:
bq.      The interface is kind of similar, but very flexible. Any problem with that?
bq.  
bq.  Michael Stack wrote:
bq.      On 'Any problem with that?', no.  Just trying to avoid redundancy that makes the
Interface imprecise and therefore hard to grok.
bq.  
bq.  Jimmy Xiang wrote:
bq.      I see.  I will remove the region from Get. It is ok not to support multiGet, right?
bq.  
bq.  Michael Stack wrote:
bq.      We should support multiget, yes.  Do you have to make a new message to do that if
you remove the regionspec from Get?  If so, maybe that is ok?  If not, i'm fine w/ it as optional
regionspec in Get.  I think it would be fine to purge regionspec from the Get, Put, Delete,
objects and then add messages to support multactions.  Up to you.  Just doc it and be consistent
(smile).

Got it.


bq.  On 2012-03-26 23:21:58, Michael Stack wrote:
bq.  > src/main/proto/RegionClient.proto, line 214
bq.  > <https://reviews.apache.org/r/4054/diff/5/?file=95916#file95916line214>
bq.  >
bq.  >     Yeah, why have regionspecified in the mutate if you are going to provide it
as a param too?
bq.  
bq.  Jimmy Xiang wrote:
bq.      The same reason as for Get.  It is used as a default region in case all/most mutates
are for a same region.
bq.  
bq.  Michael Stack wrote:
bq.      Having 'default' region doesn't sound right, even if you are trying to be flexible.
bq.  
bq.  Jimmy Xiang wrote:
bq.      I see. For get, we put the region in the request level.  I prefer to do the same
for mutate.  But if we put the region in request for mutate, we have to have a several
bq.      call to handle RowMutations in the same call.  I can try to handle RowMutations in
the multi call.
bq.      
bq.      Another thing is that, if we put the region in the request level, do we need to support
multiple Get per get request?  How about multiple Mutate per mutate request?
bq.  
bq.  Michael Stack wrote:
bq.      On "I can try to handle RowMutations in the multi call.", good.   So, we won't do
multiple calls to do many?

That's right. We don't do multiple calls to do many.  I will simplify the interface.


- Jimmy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4054/#review6365
-----------------------------------------------------------


On 2012-03-26 20:14:22, Jimmy Xiang wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4054/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-03-26 20:14:22)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  This is the first draft of the ProtoBuff HRegionProtocol.  The corresponding java vs
pb method mapping is attached to the jira: https://issues.apache.org/jira/browse/HBASE-5443
bq.  
bq.  Please review.  I'd like to move ahead after we get to some agreement.
bq.  
bq.  
bq.  This addresses bug HBASE-5619.
bq.      https://issues.apache.org/jira/browse/HBASE-5619
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    pom.xml 10b13ef 
bq.    src/main/proto/RegionAdmin.proto PRE-CREATION 
bq.    src/main/proto/RegionClient.proto PRE-CREATION 
bq.    src/main/proto/hbase.proto PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/4054/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Jimmy
bq.  
bq.


                
> Create PB protocols for HRegionInterface
> ----------------------------------------
>
>                 Key: HBASE-5619
>                 URL: https://issues.apache.org/jira/browse/HBASE-5619
>             Project: HBase
>          Issue Type: Sub-task
>          Components: ipc, master, migration, regionserver
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.96.0
>
>         Attachments: hbase-5619.patch, hbase-5619_v3.patch
>
>
> Subtask of HBase-5443, separate HRegionInterface into admin protocol and client protocol,
create the PB protocol buffer files

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message