hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5335) Dynamic Schema Configurations
Date Fri, 16 Mar 2012 23:08:41 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231725#comment-13231725
] 

Phabricator commented on HBASE-5335:
------------------------------------

stack has commented on the revision "[jira] [HBASE-5335] Dynamic Schema Config".

  A few minors.  Looks good.  Will need fat release note when committed.  Lars, might go into
0.94?

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java:776 This looks nice in the
output?
  src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java:582 Seems like some of this
method could be unified w/ the HCD#getValues (as per Ted comment)
  src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:947 What is the dedupe problem?
 Dedup of HTD properties?
  src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:938 Does this have to be
public? Only used inside this package?
  src/main/java/org/apache/hadoop/hbase/util/CompoundConfiguration.java:1 Configuration in
hadoop is in the conf package.  Should we have one in hbase.  We could put this there.   Or,
earlier I suggest it be an inner class of HBaseConfiguration or just a feature of HBC... you
ignored that comment 'cos it silly?
  src/main/ruby/hbase/admin.rb:187 How does this work in shell?  I can't picture it looking
at code.  Looks like user says ADVANCED and then passes k/vs?   If so, how you think we going
to explain notion of ADVANCED?
  src/test/java/org/apache/hadoop/hbase/HBaseTestCase.java:169 Hmm... above I suggest this
be a package private method but see here it needs to be public... at least for this test.

REVISION DETAIL
  https://reviews.facebook.net/D2247

                
> Dynamic Schema Configurations
> -----------------------------
>
>                 Key: HBASE-5335
>                 URL: https://issues.apache.org/jira/browse/HBASE-5335
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Nicolas Spiegelberg
>            Assignee: Nicolas Spiegelberg
>              Labels: configuration, schema
>         Attachments: D2247.1.patch, D2247.2.patch
>
>
> Currently, the ability for a core developer to add per-table & per-CF configuration
settings is very heavyweight.  You need to add a reserved keyword all the way up the stack
& you have to support this variable long-term if you're going to expose it explicitly
to the user.  This has ended up with using Configuration.get() a lot because it is lightweight
and you can tweak settings while you're trying to understand system behavior [since there
are many config params that may never need to be tuned].  We need to add the ability to put
& read arbitrary KV settings in the HBase schema.  Combined with online schema change,
this will allow us to safely iterate on configuration settings.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message