hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hsieh (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5598) Analyse and fix the findbugs reporting by QA and add invalid bugs into findbugs-excludeFilter file
Date Tue, 27 Mar 2012 14:20:30 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239490#comment-13239490
] 

Jonathan Hsieh commented on HBASE-5598:
---------------------------------------

Uma, good stuff.  Please take a look at this thread from the mailing list if you haven't seen
it yet.

http://mail-archives.apache.org/mod_mbox/hbase-dev/201203.mbox/browser

I'd suggest updating the findbugs warning count in dev-support/test-patch.properties.  Mind
moving it over to HBASE-5642?  We can keep this on as the umbrella issue.

For the other folks interested, here's some link on how to add findbugs/findbugs excludes
for those who want to jump on some issues.

http://findbugs.sourceforge.net/manual/filter.html
http://mojo.codehaus.org/findbugs-maven-plugin-2.4.0/

You can run findbugs locally via 'mvn findbugs:findbugs'.  I thought we auto gen'ed the file
for the website -- making findbugs run and generate html when 'mvn site' is run might be another
subtask to add.

                
> Analyse and fix the findbugs reporting by QA and add invalid bugs into findbugs-excludeFilter
file
> --------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5598
>                 URL: https://issues.apache.org/jira/browse/HBASE-5598
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.92.1, 0.94.0, 0.96.0
>            Reporter: Uma Maheswara Rao G
>            Assignee: Uma Maheswara Rao G
>            Priority: Minor
>         Attachments: HBASE-5598.patch, findbugs-gui-report.jpg
>
>
> There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to up the OK
count.
> This may lead to other issues when we re-factor the code, if we induce new valid ones
and remove invalid bugs also can not be reported by QA.
> So, I would propose to add the exclude filter file for findbugs(for the invalid bugs).
If we find any valid ones, we can fix under this JIRA.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message