hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5335) Dynamic Schema Configurations
Date Mon, 19 Mar 2012 21:49:38 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232946#comment-13232946
] 

Phabricator commented on HBASE-5335:
------------------------------------

nspiegelberg has commented on the revision "[jira] [HBASE-5335] Dynamic Schema Config".

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java:760 actually, the purpose was
to dissuade people from using this unless they know what they're doing.  we don't want people
randomly putting keys in here without looking at the source code and then wondering why it
doesn't work.  make sense? do you have another suggestion?
  src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java:753 we don't currently have
any config variables with single quotes, do we?  it's much more developer-controlled than
user input.  I guess I should do some basic sanitization for the user error case.  the important
ability is that the user can mistakenly enter a key with a single quote and then delete it
  src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java:783 this is a shallow pointer
copy, not a deep KV copy
  src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java:41 @mbautin: ted's point is
that this will be in client code, so every app server & MapReduce cluster would need to
have the Guava dependency installed versus just the HBase server deployment.

REVISION DETAIL
  https://reviews.facebook.net/D2247

                
> Dynamic Schema Configurations
> -----------------------------
>
>                 Key: HBASE-5335
>                 URL: https://issues.apache.org/jira/browse/HBASE-5335
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Nicolas Spiegelberg
>            Assignee: Nicolas Spiegelberg
>              Labels: configuration, schema
>         Attachments: D2247.1.patch, D2247.2.patch, D2247.3.patch
>
>
> Currently, the ability for a core developer to add per-table & per-CF configuration
settings is very heavyweight.  You need to add a reserved keyword all the way up the stack
& you have to support this variable long-term if you're going to expose it explicitly
to the user.  This has ended up with using Configuration.get() a lot because it is lightweight
and you can tweak settings while you're trying to understand system behavior [since there
are many config params that may never need to be tuned].  We need to add the ability to put
& read arbitrary KV settings in the HBase schema.  Combined with online schema change,
this will allow us to safely iterate on configuration settings.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message