hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jean-Daniel Cryans (Created) (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HBASE-5639) The logic used in waiting for region servers during startup is broken
Date Mon, 26 Mar 2012 23:12:27 GMT
The logic used in waiting for region servers during startup is broken
---------------------------------------------------------------------

                 Key: HBASE-5639
                 URL: https://issues.apache.org/jira/browse/HBASE-5639
             Project: HBase
          Issue Type: Bug
            Reporter: Jean-Daniel Cryans
            Assignee: nkeywal
            Priority: Blocker
             Fix For: 0.94.0


See the tail of HBASE-4993, which I'll report here:

Me:
{quote}
I think a bug was introduced here. Here's the new waiting logic in waitForRegionServers:

the 'hbase.master.wait.on.regionservers.mintostart' is reached AND
   there have been no new region server in for
      'hbase.master.wait.on.regionservers.interval' time

And the code that verifies that:

!(lastCountChange+interval > now && count >= minToStart)
{quote}

Nic:
{quote}
It seems that changing the code to

(count < minToStart ||
lastCountChange+interval > now)

would make the code works as documented.
If you have 0 region servers that checked in and you are under the interval, you wait: (true
or true) = true.
If you have 0 region servers but you are above the interval, you wait: (true or false) = true.
If you have 1 or more region servers that checked in and you are under the interval, you wait:
(false or true) = true.
{quote}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message