hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5619) Create PB protocols for HRegionInterface
Date Thu, 22 Mar 2012 20:18:22 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235972#comment-13235972
] 

jiraposter@reviews.apache.org commented on HBASE-5619:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4054/
-----------------------------------------------------------

(Updated 2012-03-22 20:17:03.965254)


Review request for hbase.


Changes
-------

HBASE-5443 is split into individual tasks. This one is about the protocol buffer definitions:
HBASE-5619

Most of the review comments are addressed.


Summary
-------

This is the first draft of the ProtoBuff HRegionProtocol.  The corresponding java vs pb method
mapping is attached to the jira: https://issues.apache.org/jira/browse/HBASE-5443

Please review.  I'd like to move ahead after we get to some agreement.


This addresses bug HBASE-5619.
    https://issues.apache.org/jira/browse/HBASE-5619


Diffs (updated)
-----

  pom.xml 10b13ef 
  src/main/proto/RegionAdmin.proto PRE-CREATION 
  src/main/proto/RegionClient.proto PRE-CREATION 
  src/main/proto/hbase.proto PRE-CREATION 

Diff: https://reviews.apache.org/r/4054/diff


Testing
-------


Thanks,

Jimmy


                
> Create PB protocols for HRegionInterface
> ----------------------------------------
>
>                 Key: HBASE-5619
>                 URL: https://issues.apache.org/jira/browse/HBASE-5619
>             Project: HBase
>          Issue Type: Sub-task
>          Components: ipc, master, migration, regionserver
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.96.0
>
>         Attachments: hbase-5619.patch
>
>
> Subtask of HBase-5443, separate HRegionInterface into admin protocol and client protocol,
create the PB protocol buffer files

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message