hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5541) Avoid holding the rowlock during HLog sync in HRegion.mutateRowWithLocks
Date Fri, 09 Mar 2012 06:35:57 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225882#comment-13225882
] 

stack commented on HBASE-5541:
------------------------------

Commit is fine.

What about case where the edits are applied, sync succeeds, but the cp postdelete and postput
fail?  Then mvcc will have been updated but we have removed the edits from memstore.

i suppose its ok?  The read point is advanced but if we take this edit in isolation, no mutations
made it through?
                
> Avoid holding the rowlock during HLog sync in HRegion.mutateRowWithLocks
> ------------------------------------------------------------------------
>
>                 Key: HBASE-5541
>                 URL: https://issues.apache.org/jira/browse/HBASE-5541
>             Project: HBase
>          Issue Type: Sub-task
>          Components: client, regionserver
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>             Fix For: 0.94.0
>
>         Attachments: 5541-v2.txt, 5541.txt
>
>
> Currently mutateRowsWithLocks holds the row lock while the HLog is sync'ed.
> Similar to what we do in doMiniBatchPut, we should create the log entry with the lock
held, but only sync the HLog after the lock is released, along with rollback logic in case
the sync'ing fails.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message