hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5619) Create PB protocols for HRegionInterface
Date Tue, 27 Mar 2012 22:36:30 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240021#comment-13240021
] 

jiraposter@reviews.apache.org commented on HBASE-5619:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4054/#review6453
-----------------------------------------------------------

Ship it!


I'm game for committing this.  My guess is that it'll need some massage before we arrive at
final for 0.96.  Will let this bake a day or so before making actual commit in case someone
else wants to take a looksee.  Nice stuff Jimmy


src/main/protobuf/RegionClient.proto
<https://reviews.apache.org/r/4054/#comment14078>

    This seems off.



src/main/protobuf/RegionClient.proto
<https://reviews.apache.org/r/4054/#comment14079>

    Great



src/main/protobuf/RegionClient.proto
<https://reviews.apache.org/r/4054/#comment14080>

    Great



src/main/protobuf/RegionClient.proto
<https://reviews.apache.org/r/4054/#comment14081>

    oh, here is getclosestrowbefore.  good.  easy to remove.



src/main/protobuf/RegionClient.proto
<https://reviews.apache.org/r/4054/#comment14082>

    Does this break if qualifier is null?  It should work?



src/main/protobuf/RegionClient.proto
<https://reviews.apache.org/r/4054/#comment14083>

    This modeling seems a little odd.   I'd think that a Mutate would have a column and then
a ts and a value but lets leave it this way.  My guess is that you've figured that this will
make your life easier going forward (if so, lets keep this 'model'...)



src/main/protobuf/RegionClient.proto
<https://reviews.apache.org/r/4054/#comment14085>

    So, can an open scanner return results?  Curently returns scanid only.  This looks like
it could return scanid AND first set of results.  That'd be cool.


- Michael


On 2012-03-27 21:57:06, Jimmy Xiang wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4054/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-03-27 21:57:06)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  This is the first draft of the ProtoBuff HRegionProtocol.  The corresponding java vs
pb method mapping is attached to the jira: https://issues.apache.org/jira/browse/HBASE-5443
bq.  
bq.  Please review.  I'd like to move ahead after we get to some agreement.
bq.  
bq.  
bq.  This addresses bug HBASE-5619.
bq.      https://issues.apache.org/jira/browse/HBASE-5619
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    pom.xml 10b13ef 
bq.    src/main/protobuf/RegionAdmin.proto PRE-CREATION 
bq.    src/main/protobuf/RegionClient.proto PRE-CREATION 
bq.    src/main/protobuf/hbase.proto PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/4054/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Jimmy
bq.  
bq.


                
> Create PB protocols for HRegionInterface
> ----------------------------------------
>
>                 Key: HBASE-5619
>                 URL: https://issues.apache.org/jira/browse/HBASE-5619
>             Project: HBase
>          Issue Type: Sub-task
>          Components: ipc, master, migration, regionserver
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.96.0
>
>         Attachments: hbase-5619.patch, hbase-5619_v3.patch, hbase-5619_v4.patch
>
>
> Subtask of HBase-5443, separate HRegionInterface into admin protocol and client protocol,
create the PB protocol buffer files

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message