hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5328) Small changes to Master to make it more testable
Date Wed, 21 Mar 2012 19:52:44 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234944#comment-13234944
] 

jiraposter@reviews.apache.org commented on HBASE-5328:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4436/
-----------------------------------------------------------

Review request for hbase.


Summary
-------

M src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java
  Make this class public so its waitForRoot(long) can be used by HMaster.
  Remove the stalling waitForRoot no arg.
M src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
  Javadoc.  Add check if stopped flag cycling waiting on assignment.
M src/main/java/org/apache/hadoop/hbase/master/HMaster.java
  Moved check if schema change flag out to a method rather than
  have it on tail of constructor.
  Moved other initialization stuff like get of assignment manager
  and server manager out into methods so could be intercepted by
  tests and mocking.
  Change how we wait on root so we sleep 100ms at a time and always
  check stopped flag rather than block for ever.
  Added more checking if stopped flag.
  Added flag for when rpc server is up, mostly for tests.
M src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java
  Unused import.
M src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
  Comment.
M src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
  Remove unused code.
M src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java
  Change how we wait on root.  DOn't use removed method.
A src/test/java/org/apache/hadoop/hbase/master/MockRegionS


This addresses bug hbase-5328.
    https://issues.apache.org/jira/browse/hbase-5328


Diffs
-----

  src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 79b6604 
  src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java 90fa45a 
  src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java PRE-CREATION 
  src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 7f97b01 
  src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java a929e31 
  src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java d47ef10 
  src/main/java/org/apache/hadoop/hbase/master/HMaster.java 0d7cbeb 
  src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java beaff97 
  src/test/java/org/apache/hadoop/hbase/master/Mocking.java PRE-CREATION 
  src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java 841649a 
  src/test/java/org/apache/hadoop/hbase/master/TestMasterNoCluster.java PRE-CREATION 

Diff: https://reviews.apache.org/r/4436/diff


Testing
-------


Thanks,

Michael


                
> Small changes to Master to make it more testable
> ------------------------------------------------
>
>                 Key: HBASE-5328
>                 URL: https://issues.apache.org/jira/browse/HBASE-5328
>             Project: HBase
>          Issue Type: Task
>            Reporter: stack
>            Assignee: stack
>         Attachments: 5328.txt, 5328v2.txt, 5328v2.txt
>
>
> Here are some small changes in Master that make it more testable.  Included tests stand
up a Master and then fake it into thinking that three regionservers are registering making
master assign root and meta, etc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message