hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5128) [uber hbck] Enable hbck to automatically repair table integrity problems as well as region consistency problems while online.
Date Thu, 22 Mar 2012 05:18:24 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235357#comment-13235357
] 

jiraposter@reviews.apache.org commented on HBASE-5128:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3435/
-----------------------------------------------------------

(Updated 2012-03-22 05:16:09.079201)


Review request for hbase, Todd Lipcon, Ted Yu, Michael Stack, and Jean-Daniel Cryans.


Changes
-------

Updated with safeguard features found in trunk/0.94/0.92 versions.


Summary (updated)
-------

This should nearly be to ready for integration.  This has the same control flow as the trunk/0.92/0.94
versions but has a few differences.  

- It needs to track HTableDescritors instead of reading them from the file system.
- It uses a different HBaseFsckRepair.forceOfflineInZK method -- which for some reason means
we don't need HBASE-5563.
- Uses HServerAddress instead of ServerName

This version is close to what we've used on production clusters.


This addresses bug HBASE-5128.
    https://issues.apache.org/jira/browse/HBASE-5128


Diffs (updated)
-----

  src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java de6ebe3 
  src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 7404377 
  src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1ec17cd 
  src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 6d3401d 
  src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java a3d8b8b 
  src/main/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRepair.java 29e8bb2 
  src/main/java/org/apache/hadoop/hbase/util/hbck/TableIntegrityErrorHandler.java PRE-CREATION

  src/main/java/org/apache/hadoop/hbase/util/hbck/TableIntegrityErrorHandlerImpl.java PRE-CREATION

  src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java 7138d63 
  src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java a640d57 
  src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsckComparator.java 2c4a79e 
  src/test/java/org/apache/hadoop/hbase/util/hbck/HbckTestingUtil.java dbb97f8 
  src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildHole.java 11a1151


Diff: https://reviews.apache.org/r/3435/diff


Testing (updated)
-------

All TestHBaseFsck unit tests pass.  Currently running full suite.


Thanks,

jmhsieh


                
> [uber hbck] Enable hbck to automatically repair table integrity problems as well as region
consistency problems while online.
> -----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5128
>                 URL: https://issues.apache.org/jira/browse/HBASE-5128
>             Project: HBase
>          Issue Type: New Feature
>          Components: hbck
>    Affects Versions: 0.90.5, 0.92.0, 0.94.0, 0.96.0
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>             Fix For: 0.90.7, 0.92.2, 0.94.0, 0.96.0
>
>         Attachments: hbase-5128-0.90-v2.patch, hbase-5128-0.92-v2.patch, hbase-5128-0.94-v2.patch,
hbase-5128-trunk-v2.patch, hbase-5128-trunk.patch
>
>
> The current (0.90.5, 0.92.0rc2) versions of hbck detects most of region consistency and
table integrity invariant violations.  However with '-fix' it can only automatically repair
region consistency cases having to do with deployment problems.  This updated version should
be able to handle all cases (including a new orphan regiondir case).  When complete will likely
deprecate the OfflineMetaRepair tool and subsume several open META-hole related issue.
> Here's the approach (from the comment of at the top of the new version of the file).
> {code}
> /**
>  * HBaseFsck (hbck) is a tool for checking and repairing region consistency and
>  * table integrity.  
>  * 
>  * Region consistency checks verify that META, region deployment on
>  * region servers and the state of data in HDFS (.regioninfo files) all are in
>  * accordance. 
>  * 
>  * Table integrity checks verify that that all possible row keys can resolve to
>  * exactly one region of a table.  This means there are no individual degenerate
>  * or backwards regions; no holes between regions; and that there no overlapping
>  * regions. 
>  * 
>  * The general repair strategy works in these steps.
>  * 1) Repair Table Integrity on HDFS. (merge or fabricate regions)
>  * 2) Repair Region Consistency with META and assignments
>  * 
>  * For table integrity repairs, the tables their region directories are scanned
>  * for .regioninfo files.  Each table's integrity is then verified.  If there 
>  * are any orphan regions (regions with no .regioninfo files), or holes, new 
>  * regions are fabricated.  Backwards regions are sidelined as well as empty
>  * degenerate (endkey==startkey) regions.  If there are any overlapping regions,
>  * a new region is created and all data is merged into the new region.  
>  * 
>  * Table integrity repairs deal solely with HDFS and can be done offline -- the
>  * hbase region servers or master do not need to be running.  These phase can be
>  * use to completely reconstruct the META table in an offline fashion. 
>  * 
>  * Region consistency requires three conditions -- 1) valid .regioninfo file 
>  * present in an hdfs region dir,  2) valid row with .regioninfo data in META,
>  * and 3) a region is deployed only at the regionserver that is was assigned to.
>  * 
>  * Region consistency requires hbck to contact the HBase master and region
>  * servers, so the connect() must first be called successfully.  Much of the
>  * region consistency information is transient and less risky to repair.
>  */
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message