hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hsieh (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5638) Backport to 0.90 and 0.92 - NPE reading ZK config in HBase
Date Thu, 29 Mar 2012 08:27:35 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241077#comment-13241077
] 

Jonathan Hsieh commented on HBASE-5638:
---------------------------------------

Matteo, 

We should probably use the built-in boolean parser in configuration instead of doing a the
string compare -- something like this:

{code}
if (conf.getBoolean(HConstants.CLUSTER_DISTRIBUTED, HConstants.DEFAULT_CLUSTER_DISTRIBUTED))
{code}

see: http://hadoop.apache.org/common/docs/current/api/org/apache/hadoop/conf/Configuration.html#getBoolean(java.lang.String,
boolean)

We'd also end up changing HConstants.DEFAULT_CLUSTER_DISTRBUTED to be a boolean type instead
of a string as well.


                
> Backport to 0.90 and 0.92 - NPE reading ZK config in HBase
> ----------------------------------------------------------
>
>                 Key: HBASE-5638
>                 URL: https://issues.apache.org/jira/browse/HBASE-5638
>             Project: HBase
>          Issue Type: Sub-task
>          Components: zookeeper
>    Affects Versions: 0.90.6, 0.92.1
>            Reporter: Matteo Bertozzi
>            Priority: Minor
>             Fix For: 0.90.7, 0.92.2
>
>         Attachments: HBASE-5633-0.90.patch, HBASE-5633-0.92.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message