hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5670) Have Mutation implement the Row interface.
Date Thu, 29 Mar 2012 02:19:31 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240924#comment-13240924

Hadoop QA commented on HBASE-5670:

-1 overall.  Here are the results of testing the latest attachment 
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit

     -1 core tests.  The patch failed these unit tests:

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1335//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1335//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1335//console

This message is automatically generated.
> Have Mutation implement the Row interface.
> ------------------------------------------
>                 Key: HBASE-5670
>                 URL: https://issues.apache.org/jira/browse/HBASE-5670
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>            Priority: Trivial
>             Fix For: 0.94.1
>         Attachments: 5670-0.94.txt, 5670-trunk.txt
> In HBASE-4347 I factored some code from Put/Delete/Append in Mutation.
> In a discussion with a co-worker I noticed that Put/Delete/Append still implement the
Row interface, but Mutation does not.
> In a trivial change I would like to move that interface up to Mutation, along with changing
HTable.batch(List<Row>) to HTable.batch(List<? extends Row>) (HConnection.processBatch
takes List<? extends Row> already anyway), so that HTable.batch can be used with a list
of Mutations.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message