hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5335) Dynamic Schema Configurations
Date Mon, 19 Mar 2012 21:17:39 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232915#comment-13232915

Phabricator commented on HBASE-5335:

mbautin has commented on the revision "[jira] [HBASE-5335] Dynamic Schema Config".

  A few initial comments (unfortunately on an earlier version of the revision).

  src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java:748 Use containsKey
  src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java:753 Are we trying to make the
output jruby-parseable? If so, we need to take care of escaping embedded single quotes here.
  src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java:760 HConstants.ADVANCED sounds
confusing. I think we need that constant to have a more descriptive name.
  src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java:773-775 See my earlier comment
about escaping embedded single quotes. The escaping method also needs to be shared between
all callsites.
  src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java:783 Is it possible to create
the unmodifiable map once instead of every time this is called?
  src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java:41 I might have missed some
earlier discussion, but why exactly is a Guava dependency a bad thing? Guava is licensed under
Apache License 2.0 according to http://code.google.com/p/guava-libraries/.


> Dynamic Schema Configurations
> -----------------------------
>                 Key: HBASE-5335
>                 URL: https://issues.apache.org/jira/browse/HBASE-5335
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Nicolas Spiegelberg
>            Assignee: Nicolas Spiegelberg
>              Labels: configuration, schema
>         Attachments: D2247.1.patch, D2247.2.patch, D2247.3.patch
> Currently, the ability for a core developer to add per-table & per-CF configuration
settings is very heavyweight.  You need to add a reserved keyword all the way up the stack
& you have to support this variable long-term if you're going to expose it explicitly
to the user.  This has ended up with using Configuration.get() a lot because it is lightweight
and you can tweak settings while you're trying to understand system behavior [since there
are many config params that may never need to be tuned].  We need to add the ability to put
& read arbitrary KV settings in the HBase schema.  Combined with online schema change,
this will allow us to safely iterate on configuration settings.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message