hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5619) Create PB protocols for HRegionInterface
Date Fri, 23 Mar 2012 17:55:30 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236846#comment-13236846
] 

jiraposter@reviews.apache.org commented on HBASE-5619:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4054/#review6294
-----------------------------------------------------------


Looks good overall.
Minor comments below.


src/main/proto/RegionAdmin.proto
<https://reviews.apache.org/r/4054/#comment13644>

    Is it possible that clusterIdLeastSignificantBits is present but clusterIdMostSignificantBits
is absent ?



src/main/proto/RegionAdmin.proto
<https://reviews.apache.org/r/4054/#comment13646>

    Should this rpc be called getOnlineRegions ?



src/main/proto/RegionClient.proto
<https://reviews.apache.org/r/4054/#comment13647>

    Increment doesn't extend Mutation:
    
    public class Increment implements Row {
    



src/main/proto/RegionClient.proto
<https://reviews.apache.org/r/4054/#comment13649>

    Remove 'is'



src/main/proto/RegionClient.proto
<https://reviews.apache.org/r/4054/#comment13651>

    white space.



src/main/proto/RegionClient.proto
<https://reviews.apache.org/r/4054/#comment13652>

    Should this line be removed ?



src/main/proto/RegionClient.proto
<https://reviews.apache.org/r/4054/#comment13653>

    'it's appeared' -> 'it appears'



src/main/proto/RegionClient.proto
<https://reviews.apache.org/r/4054/#comment13654>

    I don't see region member in Exec.java
    Do we need this ?


- Ted


On 2012-03-22 20:20:39, Jimmy Xiang wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4054/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-03-22 20:20:39)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  This is the first draft of the ProtoBuff HRegionProtocol.  The corresponding java vs
pb method mapping is attached to the jira: https://issues.apache.org/jira/browse/HBASE-5443
bq.  
bq.  Please review.  I'd like to move ahead after we get to some agreement.
bq.  
bq.  
bq.  This addresses bug HBASE-5619.
bq.      https://issues.apache.org/jira/browse/HBASE-5619
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    pom.xml 10b13ef 
bq.    src/main/proto/RegionAdmin.proto PRE-CREATION 
bq.    src/main/proto/RegionClient.proto PRE-CREATION 
bq.    src/main/proto/hbase.proto PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/4054/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Jimmy
bq.  
bq.


                
> Create PB protocols for HRegionInterface
> ----------------------------------------
>
>                 Key: HBASE-5619
>                 URL: https://issues.apache.org/jira/browse/HBASE-5619
>             Project: HBase
>          Issue Type: Sub-task
>          Components: ipc, master, migration, regionserver
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.96.0
>
>         Attachments: hbase-5619.patch
>
>
> Subtask of HBase-5443, separate HRegionInterface into admin protocol and client protocol,
create the PB protocol buffer files

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message