hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4608) HLog Compression
Date Thu, 15 Mar 2012 04:06:01 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229871#comment-13229871
] 

jiraposter@reviews.apache.org commented on HBASE-4608:
------------------------------------------------------



bq.  On 2012-03-14 23:54:37, Ted Yu wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/regionserver/wal/Compressor.java, line 164
bq.  > <https://reviews.apache.org/r/4328/diff/3/?file=92428#file92428line164>
bq.  >
bq.  >     Please add javadoc for offset and length.

Are you joking?  On a protected method with parameter names such as these that follow a byte
array argument? 


bq.  On 2012-03-14 23:54:37, Ted Yu wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressionContext.java,
line 36
bq.  > <https://reviews.apache.org/r/4328/diff/3/?file=92427#file92427line36>
bq.  >
bq.  >     IllegalArgumentException is not needed here.
bq.  >     I removed it, compiled and ran TestCompressor - it passed.

Removed.


bq.  On 2012-03-14 23:54:37, Ted Yu wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/regionserver/wal/Compressor.java, line 108
bq.  > <https://reviews.apache.org/r/4328/diff/3/?file=92428#file92428line108>
bq.  >
bq.  >     A closing ) should be placed either on this line or on line 109.

done


bq.  On 2012-03-14 23:54:37, Ted Yu wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/regionserver/wal/Compressor.java, line 143
bq.  > <https://reviews.apache.org/r/4328/diff/3/?file=92428#file92428line143>
bq.  >
bq.  >     Should read 'byte of index to the ...'

done


bq.  On 2012-03-14 23:54:37, Ted Yu wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogKey.java, line 55
bq.  > <https://reviews.apache.org/r/4328/diff/3/?file=92431#file92431line55>
bq.  >
bq.  >     I don't quite get what the second sentence is supposed to convey ?
bq.  >     It seems to be same as first sentence.
bq.  >     
bq.  >     This version is the minimum version that supports compression.

Leaving as is.  The second sentence is to emphasize that only the dictionary compression was
introduced in version -2.


bq.  On 2012-03-14 23:54:37, Ted Yu wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/regionserver/wal/LRUDictionary.java, line
33
bq.  > <https://reviews.apache.org/r/4328/diff/3/?file=92433#file92433line33>
bq.  >
bq.  >     Can we remove 'silly' here ?
bq.  >     Some user may actually reach this size.

Then they are being silly.


bq.  On 2012-03-14 23:54:37, Ted Yu wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogReader.java,
line 202
bq.  > <https://reviews.apache.org/r/4328/diff/3/?file=92434#file92434line202>
bq.  >
bq.  >     Setting reader to null would be desirable after the close() call.

Done


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4328/#review5972
-----------------------------------------------------------


On 2012-03-14 22:26:34, Michael Stack wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4328/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-03-14 22:26:34)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  See issue
bq.  
bq.  
bq.  This addresses bug hbase-4608.
bq.      https://issues.apache.org/jira/browse/hbase-4608
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    src/main/java/org/apache/hadoop/hbase/HConstants.java 045c6f3 
bq.    src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressionContext.java PRE-CREATION

bq.    src/main/java/org/apache/hadoop/hbase/regionserver/wal/Compressor.java PRE-CREATION

bq.    src/main/java/org/apache/hadoop/hbase/regionserver/wal/Dictionary.java PRE-CREATION

bq.    src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java b5049b1 
bq.    src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogKey.java 311ea1b 
bq.    src/main/java/org/apache/hadoop/hbase/regionserver/wal/KeyValueCompression.java PRE-CREATION

bq.    src/main/java/org/apache/hadoop/hbase/regionserver/wal/LRUDictionary.java PRE-CREATION

bq.    src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogReader.java ff63a5f

bq.    src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogWriter.java 01ebb5c

bq.    src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEdit.java d8f317c 
bq.    src/main/java/org/apache/hadoop/hbase/util/Bytes.java de8e40b 
bq.    src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestCompressor.java PRE-CREATION

bq.    src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestKeyValueCompression.java
PRE-CREATION 
bq.    src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLRUDictionary.java PRE-CREATION

bq.    src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java a11899c 
bq.    src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplayCompressed.java
PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/4328/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Michael
bq.  
bq.


                
> HLog Compression
> ----------------
>
>                 Key: HBASE-4608
>                 URL: https://issues.apache.org/jira/browse/HBASE-4608
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Li Pi
>            Assignee: stack
>             Fix For: 0.94.0
>
>         Attachments: 4608-v19.txt, 4608-v20.txt, 4608-v22.txt, 4608v1.txt, 4608v13.txt,
4608v13.txt, 4608v14.txt, 4608v15.txt, 4608v16.txt, 4608v17.txt, 4608v18.txt, 4608v23.txt,
4608v24.txt, 4608v25.txt, 4608v27.txt, 4608v29.txt, 4608v5.txt, 4608v6.txt, 4608v7.txt, 4608v8fixed.txt,
hbase-4608-v28-delta.txt, hbase-4608-v28.txt, hbase-4608-v28.txt
>
>
> The current bottleneck to HBase write speed is replicating the WAL appends across different
datanodes. We can speed up this process by compressing the HLog. Current plan involves using
a dictionary to compress table name, region id, cf name, and possibly other bits of repeated
data. Also, HLog format may be changed in other ways to produce a smaller HLog.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message