hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uma Maheswara Rao G (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5597) Findbugs check in test-patch.sh always fails
Date Sat, 17 Mar 2012 18:49:37 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232039#comment-13232039
] 

Uma Maheswara Rao G commented on HBASE-5597:
--------------------------------------------

{quote}
My original goal is to get test-patch.sh to pass. 
....
So I am fine with either bumping the OK findbugs count, or creating a findbugs exclusion file.
Others can chime in.
{quote}

Hi David,
 If our goal is just to make it pass , then both the ways would work. :-)
 But only my concern with upping the count is, it will create above issue which I mentioned
in my previous comment. Finally we will get trapped with the test-patch results. And we may
induce valid findbugs later( may not be reported by test-patch results due to above issue
).
                
> Findbugs check in test-patch.sh always fails
> --------------------------------------------
>
>                 Key: HBASE-5597
>                 URL: https://issues.apache.org/jira/browse/HBASE-5597
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.92.1, 0.94.0, 0.96.0
>            Reporter: David S. Wang
>            Assignee: David S. Wang
>         Attachments: HBASE-5597.patch
>
>
> "Fix" is to bump up OK findbugs count in test-patch.properties.  Agreed to on the list.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message